feat(CupertinoDatePicker): add a two points time seperator column #163417
+130
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koukibadr I think this PR picked up some infra issues we were having last week. A lot of the failed checks look unrelated. Could you rebase this PR? It's not letting me do so through Github. |
|
Okay I'll rebase my branch with the latest updates |
MitchellGoodwin
approved these changes
Mar 12, 2025
justinmc
reviewed
Mar 12, 2025
|
@justinmc thanks for review, I'll update the implementation to resolve your review comments |
justinmc
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a flag attribute to cupertino date picker to show/hide the two points seperator ":" between minutes and hours, this feature add more customization to the cupertino date picker widget.
This new flag is by default set to false and it's an optional flag, the default cupertino date picker behavior stays the same.
CupertinoDatePIcker before:
CupertinoDatePicker After
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Here's the issue in question for more details about the proposal and the use cases:
Issue#163416
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.