Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doctor): add an alternative path for the Dart plugin #163215

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix(doctor): add an alternative path for the Dart plugin #163215

merged 1 commit into from
Mar 18, 2025
+33 −6

Conversation

kszczek
Copy link
Contributor

@kszczek kszczek commented Feb 13, 2025

It seems like with some recent plugin/IDE version, the path for the Dart plugin has changed from <base path>/Dart to <base path>/dart, causing flutter doctor to incorrectly assume that the plugin is not installed.

Add dart as an alternative to the existing Dart package name.

Fixes #163214.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 13, 2025
@kszczek kszczek force-pushed the fix-dart-plugin-detection branch from 619d669 to 471dd27 Compare February 13, 2025 18:42
@bkonyi
Copy link
Contributor

bkonyi commented Feb 13, 2025

@jwren can you take a look at this? It seems strange that we'd be seeing lowercase dart in some situations.

@jwren
Copy link
Member

jwren commented Feb 14, 2025

This is surprising, the Dart plugin for IntelliJ has always been "Dart", see the bottom of https://plugins.jetbrains.com/plugin/6351-dart. @alexander-dorosko -- any idea why this might be different for some users?

@kszczek
Copy link
Contributor Author

kszczek commented Feb 14, 2025

see the bottom of https://plugins.jetbrains.com/plugin/6351-dart

I don't think that's relevant. For example, the plugin ID for Flutter is "io.flutter", yet the directory containing it is called "flutter-intellij"

For additional context, this happened after I wiped my desktop, so after a clean OS install, clean Android Studio install and clean plugin install. I don't know if an update would cause this directory to be renamed, but a clean install sure did create it lowercased.

@jwren
Copy link
Member

jwren commented Feb 18, 2025 •
edited
Loading

CC @bkonyi
Thanks @kszczek. I don't have any additional comments or concerns around this PR landing.

@kszczek
Copy link
Contributor Author

kszczek commented Mar 17, 2025

Hi @bkonyi, just checking in to see if there are any updates or if anything else is needed from my side to move this forward. Thanks!

@bkonyi
Copy link
Contributor

bkonyi commented Mar 17, 2025

Sorry for the delay! This LGTM if @jwren has no concerns.

@bkonyi bkonyi self-requested a review March 17, 2025 19:02
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 17, 2025

autosubmit label was removed for flutter/flutter/163215, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@bkonyi bkonyi requested a review from jwren March 17, 2025 19:11
@bkonyi
Copy link
Contributor

bkonyi commented Mar 17, 2025

@jwren this needs a second reviewer. Can I get your rubber stamp?

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@kszczek
fix(doctor): add an alternative path for the Dart plugin
cf7a2a5 
It seems like with some recent plugin/IDE version, the path for the
Dart plugin has changed from `<base path>/Dart` to `<base path>/dart`,
causing `flutter doctor` to incorrectly assume that the plugin is not
installed.

Add `dart` as an alternative to the existing `Dart` package name.

Fixes: flutter#163214
@kszczek kszczek force-pushed the fix-dart-plugin-detection branch from 471dd27 to cf7a2a5 Compare March 18, 2025 08:45
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit 4c35308 Mar 18, 2025
132 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@kszczek kszczek deleted the fix-dart-plugin-detection branch March 18, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwren jwren jwren approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter doctor incorrectly reports the Dart plugin as missing
3 participants
@kszczek @bkonyi @jwren