-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[widgets/raw_menu_anchor.dart] Fixed minor typos and applied style guide suggestions #162805
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
autosubmit label was removed for flutter/flutter/162805, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
@chunhtai Heads up that this is failing Google tests. |
Rebasing here so we can move this forward. The Google testing failure was unrelated to this doc change. |
Revert toString() considering MenuAnchor() has a similar override.
autosubmit label was removed for flutter/flutter/162805, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
…d style guide suggestions (flutter/flutter#162805)
This PR fixes minor typos in the RawMenuAnchor docs.
I didn't include tests because the changes are minor.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.