Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed redundant useMaterial3: true where unnecessary #162862

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed redundant useMaterial3: true where unnecessary #162862

wants to merge 2 commits into from
+157 −157

Conversation

prdalai
Copy link

@prdalai prdalai commented Feb 7, 2025 •
edited
Loading

This PR removes redundant useMaterial3: true instances in the Flutter framework, codelabs, and sample code where it is unnecessary. Since Material 3 is now the default, this flag does not need to be explicitly set.

Before:

MaterialApp(
theme: ThemeData(useMaterial3: true),
home: HomeScreen(),
);

After:

MaterialApp(
theme: ThemeData(),
home: HomeScreen(),
);

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla Google CLA
Copy link

google-cla bot commented Feb 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Feb 7, 2025
QuncCccccc
QuncCccccc reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution!

I noticed the formats are off after we remove useMaterial3: true. Could you help fix them:)

@dkwingsmt
Copy link
Contributor

There seem to be some errors, can you take a look?
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8722904101174258625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_impeller/stdout?format=raw

@justinmc justinmc mentioned this pull request Feb 20, 2025
Merged
9 tasks
@justinmc
Copy link
Contributor

There is another PR that claims to do something similar: #163376

@chunhtai
Copy link
Contributor

Hi @prdalai , looks like the ci is no happy, can you take a look?

@dkwingsmt
Copy link
Contributor

Now that #163376 is merged, is this PR no longer needed?

@dkwingsmt dkwingsmt added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc QuncCccccc left review comments

@Piinks Piinks Awaiting requested review from Piinks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prdalai @dkwingsmt @justinmc @chunhtai @QuncCccccc @pdalai