-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780
base: master
Are you sure you want to change the base?
Conversation
Ah neat, it looks like tests run automatically on GitHub. |
This is blocked on the f26 roll into Flutter. |
Is this still blocked? |
I'm not sure -- I'll run your CI again to see if it is. |
Looks like it's still blocked on an API level version update. |
How do I follow where that version update is happeneing? |
I don't know, that's why I keep retrying the dry runs to see if it's been done yet. It's something that the Flutter team has to do (uprev to the latest Fuchsia SDK version). The closest bug seems to be b/392657486, but that seems fairly generic and not specific to Flutter. |
This is a Fuchsia change to prepare for future changes to the SDK. LogSink and InspectSink will soon be routed through dictionaries, rather than explicitly. For RealmBuilders, we need to route both the dictionary and the protocol (to preserve compatibility). For CML files, we need to use the shards in the SDK instead of using explicit routes. Once the SDK shard is updated, then all SDK consumers should receive new routes. However, not everyone will necessarily be updated at the same time, which is the reason for keeping compatibility routes in RealmBuilder (to prepare for the soft transition).
b/394681733
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.