Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Remove explicit LogSink and InspectSink routing and use dictionaries instead #162780

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gbbosak
Copy link

@gbbosak gbbosak commented Feb 6, 2025

This is a Fuchsia change to prepare for future changes to the SDK. LogSink and InspectSink will soon be routed through dictionaries, rather than explicitly. For RealmBuilders, we need to route both the dictionary and the protocol (to preserve compatibility). For CML files, we need to use the shards in the SDK instead of using explicit routes. Once the SDK shard is updated, then all SDK consumers should receive new routes. However, not everyone will necessarily be updated at the same time, which is the reason for keeping compatibility routes in RealmBuilder (to prepare for the soft transition).

b/394681733

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [(Google employee)] I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • [X (exempt, SDK mechanical change only)] I added new tests to check the change I am making, or this PR is test-exempt.
  • I followed the breaking change policy and added Data Driven Fixes where supported.
  • [X (unable to test on Fuchsia, I believe it has to be merged to be tested)] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-fuchsia Fuchsia code specifically labels Feb 6, 2025
@gbbosak
Copy link
Author

gbbosak commented Feb 6, 2025

Ah neat, it looks like tests run automatically on GitHub.

@gbbosak
Copy link
Author

gbbosak commented Feb 6, 2025

This is blocked on the f26 roll into Flutter.

@chinmaygarde
Copy link
Member

Is this still blocked?

@gbbosak
Copy link
Author

gbbosak commented Feb 24, 2025

I'm not sure -- I'll run your CI again to see if it is.

@gbbosak
Copy link
Author

gbbosak commented Feb 26, 2025

Looks like it's still blocked on an API level version update.

@chinmaygarde
Copy link
Member

How do I follow where that version update is happeneing?

@gbbosak
Copy link
Author

gbbosak commented Mar 10, 2025

I don't know, that's why I keep retrying the dry runs to see if it's been done yet. It's something that the Flutter team has to do (uprev to the latest Fuchsia SDK version).

The closest bug seems to be b/392657486, but that seems fairly generic and not specific to Flutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-fuchsia Fuchsia code specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants