-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Support For 24 Hour Format In showTimePicker #162323
base: master
Are you sure you want to change the base?
Feat: Add Support For 24 Hour Format In showTimePicker #162323
Conversation
@Piinks @QuncCccccc any updates on this? |
Sorry for the late response! I will take a look asap:)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience! Overall this looks good to me:)
@QuncCccccc I've created a separate method to test the Please review and let me know if any other changes are required. |
expect(find.text(pmString), findsNothing); | ||
|
||
// When use24HourFormat: true, hours should be displayed in 24 hour format | ||
final List<String> labels00To22 = List<String>.generate(12, (int index) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this call labels00To23?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, we are multiplying indexes from 0 to 11 with 2, so it would be 00to22, right?
Linux Analyze check is failing due to 2 errors.
|
It seems that multiple actual tests are failing. Can you take a look? |
Hey, I am working on this and will update you soon! |
Summary:
Adds new parameter
use24HourFormat
inshowTimePicker
to display 24 Hour Time Format. Fixes #144919Before:
After:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.