NativePluginLoader: make the class entirely stateless #162110
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43b5603 to
c35797b
Compare
c35797b to
3f664e5
Compare
3f664e5 to
287a415
Compare
gmackall
reviewed
Mar 18, 2025
There was a problem hiding this comment.
The caching does seem to already be done in flutter.groovy but this method is also called from packages/flutter_tools/gradle/src/main/groovy/app_plugin_loader.groovy and packages/flutter_tools/gradle/module_plugin_loader.gradle, and it doesn't look like it's cached there.
Do we know that
- We will never call multiple times from either of those sites and
- at the time of first call from those sites we won't have already called the method from another site, triggering the
native_plugin_loader.groovylevel caching?
I don't know that the answer here needs to be yes to both these questions to land this, but I'd like to at least understand what impact this will have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this caching is not needed (it's already done in
flutter.groovy).Objective: make this class as simple as possible. More context: #161352 (comment)
Pre-launch Checklist
///).