Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] expose Semantics.identifier as Windows UIA AutomationId #161955

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[WIP] expose Semantics.identifier as Windows UIA AutomationId #161955

wants to merge 6 commits into from
+67 −5

Conversation

loic-peron-inetum-public
Copy link

@loic-peron-inetum-public loic-peron-inetum-public commented Jan 21, 2025 •
edited
Loading

Expose Semantics.identifier as Windows AutomationId to ease application automation.

see #148763

followup to flutter/engine#53729 and flutter/engine#53476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Jan 21, 2025
@loic-peron-inetum-public loic-peron-inetum-public changed the title expose Semantics.identifier as Windows UIA AutomationId [WIP] expose Semantics.identifier as Windows UIA AutomationId Jan 22, 2025
@chunhtai chunhtai requested a review from loic-sharma February 5, 2025 22:39
@chunhtai
Copy link
Contributor

chunhtai commented Feb 5, 2025

Hi @loic-peron-inetum-public , are you still working on this pr?

@loic-peron-inetum-public
Copy link
Author

Hi @loic-peron-inetum-public , are you still working on this pr?

Yes I am, but I have difficulties to find a Mac to fix the problems it created with the macOS desktop target, as well as time to work on the subject due to other pressing deadline.

The windows desktop changes have not been altered since last summer, and are used internally to automate tests on the project. They still seem to fulfill the intended purpose.

I intend to fix the tests as soon as possible, but I cannot make any promise.

Some concerns have been raised with enabling UIA support (flutter/engine#53476 (comment)). I have not been able to treat that and would need some guidance on this specific matter, as UIA seems mandatory for this feature: I have not been able to have AutomationId exposed without enabling UIA.

@loic-sharma loic-sharma marked this pull request as draft March 4, 2025 21:59
@loic-sharma
Copy link
Member

I've converted this into a draft while it's still a work in progress. Feel free to mark this as ready for review once you're ready! :)

@github-actions github-actions bot added platform-linux Building on or for Linux specifically platform-macos labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-linux Building on or for Linux specifically platform-macos platform-windows Building on or for Windows specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic-peron-inetum-public @chunhtai @loic-sharma