-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Revert "Pin SHAs for container images""" #113659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts previous changes that pinned container image SHAs to enable the upgrade to clang 20. The key changes include removing SHA-based version locking for various container images used in the pipeline, restoring them to tag-based references, and aligning with the upstream changes in related .NET runtime repositories.
Comments suppressed due to low confidence (1)
eng/pipelines/common/templates/pipeline-with-resources.yml:20
- Removing the SHA pin may lead to non-deterministic builds if the upstream container image is updated unexpectedly. Consider verifying that using the tag-only reference will not adversely affect stability.
image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net10.0-cross-arm
/azp run runtime-libraries-coreclr runtime-nativeaot-outerloop outerloop-linux |
No pipelines are associated with this pull request. |
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
This all looks unrelated. Look OK @sbomer? |
I think this means that azdo rejected the command and it did not run the extra legs. I do not see any NativeAOT Arm32 runs that got the previous attempt reverted. |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks. I looked at the pipelines that were run and I wondered if those were missed. Thanks for kicking them off for real. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the failures look related
/ba-g unrelated timeouts |
Also, the SDK non-deterministic crash that we suspect is related to clang 20 did not go away with the revert dotnet/sdk#47580 (comment) so it is unrelated. |
Relies on testing:
runtime-libraries-coreclr
runtime-nativeaot-outerloop
outerloop-linux