Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Revert "Pin SHAs for container images""" #113659

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

richlander
Copy link
Member

Relies on testing:

  • runtime-libraries-coreclr
  • runtime-nativeaot-outerloop
  • outerloop-linux

@Copilot Copilot bot review requested due to automatic review settings March 18, 2025 17:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts previous changes that pinned container image SHAs to enable the upgrade to clang 20. The key changes include removing SHA-based version locking for various container images used in the pipeline, restoring them to tag-based references, and aligning with the upstream changes in related .NET runtime repositories.

Comments suppressed due to low confidence (1)

eng/pipelines/common/templates/pipeline-with-resources.yml:20

  • Removing the SHA pin may lead to non-deterministic builds if the upstream container image is updated unexpectedly. Consider verifying that using the tag-only reference will not adversely affect stability.
        image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net10.0-cross-arm
@richlander
Copy link
Member Author

/azp run runtime-libraries-coreclr runtime-nativeaot-outerloop outerloop-linux

Copy link

No pipelines are associated with this pull request.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@richlander
Copy link
Member Author

This all looks unrelated. Look OK @sbomer?

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

No pipelines are associated with this pull request.

I think this means that azdo rejected the command and it did not run the extra legs. I do not see any NativeAOT Arm32 runs that got the previous attempt reverted.

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

/azp run runtime-libraries-coreclr outerloop-linux

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richlander
Copy link
Member Author

Thanks. I looked at the pipelines that were run and I wondered if those were missed. Thanks for kicking them off for real.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the failures look related

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

/ba-g unrelated timeouts

@jkotas
Copy link
Member

jkotas commented Mar 19, 2025

Also, the SDK non-deterministic crash that we suspect is related to clang 20 did not go away with the revert dotnet/sdk#47580 (comment) so it is unrelated.

@jkotas jkotas merged commit 5ab9dfe into main Mar 19, 2025
164 of 182 checks passed
@jkotas jkotas deleted the revert-113598-revert-113248-revert-113185-shaken branch March 19, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants