[release/9.0-staging] Do not substitute return values of constrained calls #113462
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #110932. The constraint would need to be resolved first.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Mar 13, 2025
jeffschwMSFT
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111030 to release/9.0-staging
/cc @MichalStrehovsky
Customer Impact
This was hit by two customers: #110932 and #113423.
Certain static interface method invocation patterns can get miscompiled into an infinite loop. Instead of calling the method, we loop forever.
Regression
Regressed when we added more dead code elimination. Dead code elimination incorrectly proves the branch as unreachable.
Testing
This was missed because it requires some luck to hit:
ifcheck.We now have a regression test for this pattern.
Risk
Low: this has been fixed in the .NET 10 branch for two months and the fix is obvious (in retrospect).
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.