-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] [Apple mobile] Enable trimming on build machines to match ILLink features #113466
base: release/9.0-staging
Are you sure you want to change the base?
[release/9.0-staging] [Apple mobile] Enable trimming on build machines to match ILLink features #113466
Conversation
…ures (dotnet#110966) Trimming is now moved trimming from Helix to AzDo (build) machines. Redundant code for maintaining ILLink features is removed.
Tagging subscribers to this area: @akoeplinger, @matouskozak |
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can treat this as tell mode.
Backport of #110966 to release/9.0-staging
Customer Impact
This PR moves trimming from Helix to AzDo (build) machines to simplify ILLink feature alignment between AzDo and Helix. Previously, when an ILLink feature was added to the SDK, we needed to manually maintain an internal setup. This change should resolve Apple mobile test failures on extra-platforms.
Regression
This is an infrastructure improvement that fixes failing tests.
Testing
Library tests on extra-platforms and ioslike pipelines.
Risk
Low. This change does not affect the shipping code.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.