Refactor external_assembly_probe to be separate from single-file bundle probing
#113356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
3 tasks
3 tasks
2b56228 to
6b4cb09
Compare
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
AaronRobinsonMSFT
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External assembly probing is not inherently tied to the idea of a bundle. This separates having an external assembly probe callback from the bundle / bundle file location idea and refactors the hooks into assembly loading into an
AssemblyProbeExtensionhelper that handles both bundle and external assembly probing.Needs #113341 to go in first.
Resolves #112706