Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Remove fgReorderBlocks #113335

Merged
merged 3 commits into from
Mar 14, 2025
Merged

JIT: Remove fgReorderBlocks #113335

merged 3 commits into from
Mar 14, 2025

Conversation

amanasifkhalid
Copy link
Member

@amanasifkhalid amanasifkhalid commented Mar 10, 2025 •
edited
Loading

Part of #107749. Now that the relevant flow opts in fgReorderBlocks have been extracted into separate phases, and the actual block reordering logic has been replaced by 3-opt, removing fgReorderBlocks should be a no-diff change.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 10, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid marked this pull request as ready for review March 11, 2025 18:11
@Copilot Copilot bot review requested due to automatic review settings March 11, 2025 18:11
Copilot
Copilot AI reviewed Mar 11, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
@amanasifkhalid
Copy link
Member Author

There are a few diffs on win-x86 due to us no longer running fgOptimizeBranch for blocks in handler regions. Previously, fgReorderBlocks would skip reordering blocks in handler regions, but if it decided not to reorder a block, it would try running branch opts on the block before the current block, which could have been in a handler region -- I suspect this was an oversight.

@dotnet/jit-contrib PTAL, thanks!

@amanasifkhalid
Copy link
Member Author

ping @dotnet/jit-contrib

@amanasifkhalid amanasifkhalid merged commit f059761 into dotnet:main Mar 14, 2025
113 checks passed
@amanasifkhalid amanasifkhalid deleted the remove-fgReorderBlocks branch March 14, 2025 21:46
@amanasifkhalid amanasifkhalid mentioned this pull request Mar 17, 2025
Merged
amanasifkhalid added a commit that referenced this pull request Mar 17, 2025
@amanasifkhalid
JIT: Remove jitoldlayout test configs (#113621)
555d2ef 
Follow-up to #113335. There is no longer any old layout implementation to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanasifkhalid @AndyAyersMS