[release/8.0-staging] remove extra assert from WinHttp handler #112861
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
|
This heavily impacts our test runs in 8.0.x. The fix is already in 9 and 10, with minimal change - we should take it to unblock WinHTTP test runs in 8.0.x. |
karelz
approved these changes
Feb 25, 2025
rzikm
approved these changes
Mar 3, 2025
ManickaP
reviewed
Mar 3, 2025
| @@ -4,8 +4,8 @@ | |||
| <IncludeDllSafeSearchPathAttribute>true</IncludeDllSafeSearchPathAttribute> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <IsPackable>true</IsPackable> | |||
| <GeneratePackageOnBuild>false</GeneratePackageOnBuild> | |||
There was a problem hiding this comment.
@carlossanlop is this the right way to do it? I made the changes based on this: 09784cd
|
@carlossanlop could you please help me make sure I'm doing the versioning correctly here: #112861 (comment) This is not an urgent fix, so it's ok if we slipped the deadline. I'll ping the tactics once I have the above mentioned comment resolved. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
|
/ba-g infrastructure issue dotnet/dnceng#5144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #93984 to release/8.0-staging
Fixes #93099
Fixes #104891
Fixes #112700
/cc @ManickaP @wfurt
Customer Impact
Discovered in our CI, the issue is fixed since .NET 9. The problem is that from a certain Windows version, we strongly suspect WinHTTP switched to TLS 1.3 by default and hit new code paths, which ends up in
NullReferenceException, making most/all our WinHTTP tests to crash.Technical details: We see that our callback from WinHTTP is sometimes called twice. Therefore, we changed code to detect such situation by checking argument
RequestHandlefor NULL. Technically, the change just swapsassertforif not null.Regression
No (at least not in our code).
Testing
CI run confirmed that
WinHttpHandlertests do not crash.Risk
Low. Firstly, this fix is out in 9.0 and 10.0. Secondly, it's very small change replacing
assertwithif not null.