Update SqlTableAliasSimplifier to handle CTEs
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Nov 12, 2024
| mf_test_configuration: MetricFlowTestConfiguration, | ||
| sql_plan_renderer: DefaultSqlQueryPlanRenderer, | ||
| ) -> None: | ||
| """Tests that table aliases are removed when not needed in CTEs.""" |
There was a problem hiding this comment.
Should we also have a test to demonstrate that table aliases are not removed if they are needed in CTEs?
I'm assuming that would only happen if there was a join within the CTE statement. Not sure if that case will ever occur with the current CTE implementation.
There was a problem hiding this comment.
Can't hurt - added a test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the updates for the other optimizers in #1503 and #1504, this PR implements the CTE case for the
SqlTableAliasSimplifier