Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed emptyString and its remaining usage #7296

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

removed emptyString and its remaining usage #7296

wants to merge 11 commits into from

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

In my limited local tests I did not see any measurable performance impact. So posting to see if it has any effect in the CI.

@firewave
Copy link
Collaborator Author

The __GLIBC__ check only worked because of the <string>. The backtrace() function is not available on all platforms but I have not figured out how to properly check for it. So just enable it unconditionally of that and wait for some feedback. We probably should split up these preprocessor checks and make them base on the feature/function we use.

@firewave
Copy link
Collaborator Author

With the current changes there is at 11% increase in Tokenizer::simplifyTypedefCpp():

  633,270,864 ( 1.00%)  build/tokenize.cpp:Tokenizer::simplifyTypedefCpp() [/home/runner/work/cppcheck/cppcheck/cppcheck]

  704,783,980 ( 1.11%)  build/tokenize.cpp:Tokenizer::simplifyTypedefCpp() [/home/runner/work/cppcheck/cppcheck/cppcheck]

But that still doesn't account for the total increase:

63,276,354,832 (100.0%)  PROGRAM TOTALS

63,413,640,429 (100.0%)  PROGRAM TOTALS

@firewave firewave force-pushed the emptystring-z branch 4 times, most recently from 5c240c0 to 5ebf215 Compare March 11, 2025 08:26
@firewave firewave force-pushed the emptystring-z branch 3 times, most recently from 8536102 to 6d5b102 Compare March 13, 2025 07:41
firewave added 11 commits March 13, 2025 19:47
@firewave
removed emptyString and its remaining usage
aa3adda
@firewave
config.h: removed bogus check for USE_UNIX_BACKTRACE_SUPPORT
1b5349c
@firewave
stacktrace.cpp: fixed constVariablePointer selfcheck warning
424eb3d
@firewave
remove
14ee928
@firewave
small Tokenizer::isFunctionHead() optimization
4c62867
@firewave
tokenize.cpp: avoid unnecessary copies with ScopeInfo3::addChild() …
1f1d87a 
…[skip ci]
@firewave
TestToken: added test for update_property_info()
d110812
@firewave
Token: only look up control-flow keywords in update_property_info()…
3cee371 
… if necessary
@firewave
Token: only look up standard types in update_property_info() if nec…
07f90be 
…essary
@firewave
Token: avoid always false control-flow lookup in `update_property_inf…
0353cfe 
…o()` [skip ci]
@firewave
refs #13698/#10663 - symboldatabase.cpp: moved up some conditions in …
9dc139b 
…`parsedecl()` to reduce impossible container lookups [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@firewave