Support SOCSK5 proxy for BT UDP Trackers and DHT connections #1857
+792
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inherienting DHTConnectionImpl that is used by UDP trackers and DHT connections
Rename func according to RFC. Fix bad type of return. Update arg type to get bnd addr and port.
Separate sending cmd and receiving reply out as they are shared in procedures. Change returns of start* method.
|
I need this function too. |
|
btw if you need a quick SOCKS5 server you can do this: |
|
I have merged this with the current upstream head though it is a pretty old PR. I also locally tested it in a network that blocks BT (an university network actually), and it works as expected. I also built it at https://github.com/myl7/aria2/releases/tag/1.38.0-myl7.1%2B1a2d31fa since someone tells me they have difficulty building it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new class
DHTConnectionSocksProxyImplwhich inherientsDHTConnectionImpl, and is used inDHTSetup, to provide SOCKS5 proxy support for UDP connections in BT, including UDP tracker and DHT connections (asDHTConnectionImplis used by both DHT and UDP trackers despite the name).The actual SOCKS5 logic is wrapped in class
SocksProxySocket, to make it possible to reuse the logic in other features like general SOCKS5 proxy support for HTTP downloading.The PR also adds options
bt-udp-socks-proxy,bt-udp-socks-proxy-user, andbt-udp-socks-proxy-passto configure the proxy. When no proxy is set, the app fallbacks to useDHTConnectionImplthat is without proxy. Parsing and cleaning ofbt-udp-socks-proxyuses newly addedSocksProxyOptionHandler, which works likeHttpProxyOptionHandler. These UDP proxy options, though put aside other proxy options, wont be overrided byall-proxy.A test has been included in the PR. However, as the test requires a SOCKS5 proxy server, currently the test is surpressed by early returning. I would like to suggest adding a SOCKS5 proxy server as fixtures via adding a 3rd party library or asking developers to start one in advance by such as GOST.
Ref: #470 and part of #153