fix: upgrade axios to ^1.8.2 and fix tsx errors #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
previously approved these changes
Mar 13, 2025
|
Thank you! |
|
does this need package.lock checked in too? the tests are failing CI? |
|
ok. The yarn.lock is needed too? |
|
Changed commit to include yarn.lock and forgotten files for CI fix. |
|
ok now it got this "YN0028: The lockfile would have been modified by this install, which is explicitly forbidden." I never understand YARN! |
|
@soartec-lab @AllieJonsson i feel like this happens everytime right after a release? |
|
Yes, it feels the same. |
melloware
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Fix #1971
Fix #1152
Description
Upgraded Axios to version ^1.8.2 in all relevant
package.jsonfiles as requested in #1971. Additionally, fixed related TypeScript errors in two.tsxfiles caused by the Axios update. Verified changes withyarn test:ci, which completed successfully (24/24 tasks), and withyarn build, which completed successfully (10/10 tasks).