New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSSQL custom data integration type handling #5623

Open

sugimiyanto wants to merge 1 commit into mage-ai:master from sugimiyanto:feature/mssql_custom_data_integration_type_handling

Contributor

sugimiyanto commented Dec 18, 2024 •

edited

Loading

Description

MSSQL has some unique data types such as money. Currently, it's mapped as string by data integration. While I think it's supposed to be number. It will be better for user to leave the default auto-set data type by Mage when it's correct instead of checking/updating manually one by one.

How Has This Been Tested?

Column data types in MSSQL:

integration test locally Following this: https://github.com/mage-ai/mage-ai/tree/master/mage_integrations#test-in-the-mage-ui

before:

after:

Checklist

The PR is tagged with proper labels (bug, enhancement, feature, documentation)
I have performed a self-review of my own code
I have added unit tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993


          Add MSSQL custom data integration type handling

ae7176a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet