Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hw] Update the Python version from 3.10 to 3.11 in docker images #5595

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

[hw] Update the Python version from 3.10 to 3.11 in docker images #5595

wants to merge 18 commits into from

Conversation

csharplus
Copy link
Collaborator

@csharplus csharplus commented Dec 2, 2024 •
edited
Loading

Description

Address the request in #5368. Based on Status of Python versions, Python 3.11 will be officially supported till 2027-10, while Python 3.10 will reach its EOL in 2026-10 (i.e., in less than 2 years).

How Has This Been Tested?

  • Check-in builds and tests
  • Manual tests in a local development environment

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993

@csharplus csharplus self-assigned this Dec 2, 2024
@csharplus csharplus changed the title [hw] Update the Python version from 3.10 to 3.12 in docker images [hw] Update the Python version from 3.10 to 3.11 in docker images Dec 2, 2024
@csharplus csharplus changed the title [hw] Update the Python version from 3.10 to 3.11 in docker images [hw] Update the Python version from 3.10 to 3.12 in docker images Dec 2, 2024
@csharplus csharplus force-pushed the csharplus_update_docker_python_version branch from b335c0f to 5669e54 Compare December 21, 2024 08:24
@csharplus csharplus force-pushed the csharplus_update_docker_python_version branch from b0c5aec to 20018e4 Compare January 19, 2025 08:30
@csharplus csharplus changed the title [hw] Update the Python version from 3.10 to 3.12 in docker images [hw] Update the Python version from 3.10 to 3.11 in docker images Jan 19, 2025
@wangxiaoyou1993
Copy link
Member

can you make the Dockerfile with 3.11 a separate Dockerfile

@csharplus
Copy link
Collaborator Author

can you make the Dockerfile with 3.11 a separate Dockerfile

Should I create a new file only for Dockerfile, or for other docker files as well? Also, how to hook the new Docker image up with GitHub build and tests?

@wangxiaoyou1993
Copy link
Member

Dockerfile

We just need a new Dockerfile and a new dev.Dockerfile for python 3.11
The Dockerfile is used in this job https://github.com/mage-ai/mage-ai/blob/master/.github/workflows/publish_docker_image.yml
We can create a new job for python 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@csharplus csharplus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csharplus @wangxiaoyou1993