Add MQTT streaming source #5432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41c573 to
17feaa3
Compare
- Add paho_mqtt as requirements - Implement MQTT streaming source with MQTT V5 protocol
17feaa3 to
d9944bb
Compare
|
Right now, the handler is Callable[[mqtt.MqttMessage], Any], we might change that to support Serde configuration to support protobuf and avro like kafka source does. |
|
Should be ready for review @wangxiaoyou1993 I think it might be a good idea to change handler to take a dict with the same keys as mqtt.MQTTMessage to handle parsing and decoding with future support for protobuf or avro. |
sorry for the delay. will review it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add MQTT as a streaming source
Implementation relies on
paho-mqtt, batching reads is performed using a Queue to fill up messages and handling them with batch.Related #3876
Checklist