Bcftools pparallel #109
Merged
Bcftools pparallel #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much! |
This was referenced Jan 6, 2021
|
Hi Andreas! We would greatly appreciate it this update will be considered for the next release of the conda version. Thank you in advance! |
|
Absolutely. It's merged already and will be part of v2.1.6 |
|
Hi Andreas! There are updated files at Conda, but they seem to be without version bump and refer to v2.1.5. I could not find documentation what has been recently changed, but it seems that update from this PR hasn't been rolled out yet? Just want to remind about it, as it seems v2.1.6 is coming! |
|
Hi Konstantin,
2.1.5 was released last year already (see Changelog
<https://github.com/CSB5/lofreq/blob/master/Changelog>). Are you saying it
was just included in Conda? Sorry, I'm not following this closely. 2.1.6
should come soon. But since I'm maintaining this as a hobby, things take a
lot longer than I'd hoped.
Best,
Andreas
…On Fri, 16 Apr 2021 at 06:06, Kostiantyn Dreval ***@***.***> wrote:
Hi Andreas! There are updated files at Conda, but they seem to be without
version bump and refer to v2.1.5. I could not find documentation what has
been recently changed, but it seems that update from this PR hasn't been
rolled out yet? Just want to remind about it, as it seems v2.1.6 is coming!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#109 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAILSCPSOQOKVYSGYVBF6BTTI5PMVANCNFSM4VEMVMAQ>
.
--
Andreas Wilm
***@***.*** | 0x7C68FBCC
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a major issue that has been affecting us when we run Lofreq on whole genome data in somatic mode. Non-ACTGN characters in the reference (e.g. IUPAC ambiguity codes such as W, R, Y) cause strange behaviour and lead to malformed/garbled lines in the VCF somewhat consistently (see #106). The change to plp.c forces these positions to be ignored as it does for Ns in the reference. We have also changed merging to rely on bcftools in an earlier attempt to address this issue (see #108). That change may not be necessary at this point with the current patch to plp.c
I'm interested in having at least the plp.c change added to future releases of lofreq so conda users can benefit from this improvement.