Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NCISS decision points #707

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

ahouseholder
Copy link
Contributor

@ahouseholder ahouseholder commented Feb 20, 2025

Creating this as a draft so we can figure out where to go with it.

CoPilot Summary

This pull request introduces several new decision points based on the National Cyber Incident Scoring System (NCISS) and updates the documentation accordingly. The most important changes include adding new decision points, updating the documentation to reflect these additions, and modifying the navigation configuration.

New Decision Points

  • Added new decision points for Functional Impact, Incident Severity, Information Impact, Observed Activity, Observed Location of Activity, and Recoverability with corresponding Python code to model these decision points. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Documentation Updates

  • Updated the documentation to include detailed descriptions and examples for each new decision point. [1] [2] [3] [4] [5] [6] [7] [8]

Navigation Configuration

  • Modified mkdocs.yml to include the new NCISS decision points in the navigation structure.

Codebase Updates

  • Removed the __iter__ method from the SsvcDecisionPoint class in base.py as it is no longer needed.
  • Added licensing and module descriptions to the new NCISS decision point files. [1] [2]

Squashed commits:
[7e4fada] update incident severity
Squashed commits:
[f5827ab] add recoverability

add incident severity decision point
add recoverability decision point
…national-cybersecurity-incident-scoring-system

# Conflicts:
#	mkdocs.yml
@ahouseholder ahouseholder linked an issue Feb 20, 2025 that may be closed by this pull request
@ahouseholder ahouseholder self-assigned this Feb 24, 2025
@ahouseholder ahouseholder mentioned this pull request Mar 18, 2025
# Conflicts:
#	src/ssvc/decision_points/base.py
#	src/test/test_mixins.py
…oring-system

# Conflicts:
#	data/schema/v1/Decision_Point-1-0-1.schema.json
#	src/ssvc/_mixins.py
#	src/ssvc/decision_points/base.py
#	src/ssvc/namespaces.py
#	src/test/test_mixins.py
…nal-cybersecurity-incident-scoring-system

# Conflicts:
#	src/ssvc/decision_points/base.py
…national-cybersecurity-incident-scoring-system

# Conflicts:
#	src/ssvc/decision_points/base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model National Cyber Incident Scoring System (NCISS)
1 participant