-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NCISS decision points #707
Draft
ahouseholder
wants to merge
55
commits into
main
Choose a base branch
from
705-model-national-cybersecurity-incident-scoring-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add NCISS decision points #707
ahouseholder
wants to merge
55
commits into
main
from
705-model-national-cybersecurity-incident-scoring-system
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [7e4fada] update incident severity
Squashed commits: [f5827ab] add recoverability add incident severity decision point
add recoverability decision point
…national-cybersecurity-incident-scoring-system # Conflicts: # mkdocs.yml
…national-cybersecurity-incident-scoring-system
… to adjust default json output key order
…nal-cybersecurity-incident-scoring-system # Conflicts: # src/test/test_doctools.py
Merged
…national-cybersecurity-incident-scoring-system
…ty-incident-scoring-system # Conflicts: # src/ssvc/decision_points/base.py
…nal-cybersecurity-incident-scoring-system # Conflicts: # src/test/test_mixins.py
…ty-incident-scoring-system
…ty-incident-scoring-system
# Conflicts: # src/ssvc/decision_points/base.py # src/test/test_mixins.py
…oring-system # Conflicts: # data/schema/v1/Decision_Point-1-0-1.schema.json # src/ssvc/_mixins.py # src/ssvc/decision_points/base.py # src/ssvc/namespaces.py # src/test/test_mixins.py
…nal-cybersecurity-incident-scoring-system # Conflicts: # src/ssvc/decision_points/base.py
…national-cybersecurity-incident-scoring-system # Conflicts: # src/ssvc/decision_points/base.py
…ident-scoring-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as a draft so we can figure out where to go with it.
CoPilot Summary
This pull request introduces several new decision points based on the National Cyber Incident Scoring System (NCISS) and updates the documentation accordingly. The most important changes include adding new decision points, updating the documentation to reflect these additions, and modifying the navigation configuration.
New Decision Points
Functional Impact
,Incident Severity
,Information Impact
,Observed Activity
,Observed Location of Activity
, andRecoverability
with corresponding Python code to model these decision points. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation Updates
Navigation Configuration
mkdocs.yml
to include the new NCISS decision points in the navigation structure.Codebase Updates
__iter__
method from theSsvcDecisionPoint
class inbase.py
as it is no longer needed.