Page MenuHomePhabricator

MPIC: Warning message makes main layer wider
Open, LowPublic1 Estimated Story Points

Description

Description

So far we only have a form (instruments form) with a warning message that shows something related to A/B tests. After creating the new experiments forms we decided to move this warning message from the current instrument form to the new experiment one. After that, I realized that the content layer makes wider when the warning message is included (or the content layer is narrower when the warning message is not there, if you consider a different perspective).

The thing is that we have two forms and one if wider than the other due to this warning message. It's probably something related to styling but maybe we should reach out to the design team to ask for some known issues or considerations about using this component (We are using a CdxMessage to put the message)

Baseline instrument form (without the message)

Screenshot 2024-09-17 at 16.05.00.png (658×1 px, 96 KB)

A/B test form (with the message)

Screenshot 2024-09-17 at 16.04.49.png (658×1 px, 95 KB)

Something similar happens when an user types a long word as the human-readable name for the instrument.

Acceptance criteria

  • We have decided which is the right width for the content layer (the one we have with the message or the one without it)
  • A/B test or baseline instrument form layout doesn't change because the warning message
  • A/B test or baseline instrument form layout doesn't change because the human-readable name is a long word

Event Timeline

Sfaci set the point value for this task to 1.Tue, Sep 17, 3:44 PM

Following T373855: MPIC: Apply consistent max width to form elements, we should set a consistent default width of 640px for all form elements. My assumption is that applying that solution would fix this issue, and of course also make both forms consistent in width as a result. If you agree, we could make this ticket a subtask of T373855, to make sure this issue doesn't persist and tackle it separately in case it does. How does that sound?

I have found a new, maybe related/same issue. When typing a long word in the Baseline instrument name field, the page makes also wider same way the issue described in this ticket. Just posting this here to be considered when working on this.

I have also updated the description and ACs according to this

Sfaci updated the task description. (Show Details)