Page MenuHomePhabricator
Create Task
Maniphest T339897

Sentence segmentation missing in the restored translations
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

  • Start a translation between any languages, translate some paragraphs. Obseverve sentence highlighting.
  • Save and restore the translation. Observe sentence highlighting is missing

Expected result: Sentence segmentation preserved in save-restore steps

Sentence highlighting missing:Sentence highlighting present:
image.png (570×1 px, 233 KB)
image.png (570×1 px, 236 KB)

Details

SubjectRepoBranchLines +/-
CX: Use "isForSaving" mode for proper conversion of sentencesmediawiki/extensions/ContentTranslationmaster+3 -1
Customize query in gerrit

Event Timeline

santhosh created this task.Jun 20 2023, 9:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2023, 9:26 AM
gerritbot added a comment.Jun 20 2023, 9:27 AM

Change 919006 had a related patch set uploaded (by Santhosh; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Use "isForSaving" mode for proper conversion of sentences

https://gerrit.wikimedia.org/r/919006

gerritbot added a project: Patch-For-Review.Jun 20 2023, 9:27 AM
santhosh assigned this task to ngkountas.Jun 20 2023, 9:58 AM
santhosh triaged this task as High priority.
santhosh moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-April-June) board.
santhosh added a project: Regression.
gerritbot added a comment.Jun 20 2023, 10:10 AM

Change 919006 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Use "isForSaving" mode for proper conversion of sentences

https://gerrit.wikimedia.org/r/919006

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 10:31 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 20 2023, 11:00 AM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-April-June) board.Jun 29 2023, 5:02 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 11:43 AM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2023-July-September) board.
Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Jul 3 2023, 11:52 AM
EChukwukere-WMF subscribed.Aug 17 2023, 3:27 AM

Test status: QA PASS

Able to sentence highllight after saving and restoring CX translation in progress

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-July-September) board.Aug 17 2023, 3:28 AM
Pginer-WMF closed this task as Resolved.Aug 29 2023, 9:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits