Page MenuHomePhabricator

Review non-JS edits analysis
Closed, ResolvedPublic

Description

Review the initial analysis to calculate % of non-JS edits (that was requested in T240697) done by Maya.
Link for analysis provided here : https://github.com/Mayakpwiki/Measure-No-JS-edits/blob/master/JS_Edits_Support.ipynb

Event Timeline

Mayakp.wiki triaged this task as Medium priority.Jun 8 2020, 9:26 PM

Sorry for the delay @Mayakp.wiki ! The query and notebook look good. See some notes and suggested revisions below:

Overall Comments/Thoughts

  • The listed percentages on non-JS editors are much higher than expected indicating that a large portion of these users have ad-blockers installed and/or enabled DNT (as you noted). As a result, I don't think this data is useful in determining the percentage of non-JS users and we should recommend looking at adding instrumentation if more accurate numbers are needed.
  • Based on my understanding of how the events are recorded and schema documentation, this approach should really only work for the wikitext editor. Your breakdown per platform helps clarify these numbers though and confirms that there is only a small percentage for VisualEditor (I agree with your note that these might be users with DNT enabled).

Suggested Code Changes

  • I would replace 'logged' with 'user' in your query (i.e, logged_nonjs_edit to user_nonjs_edit) to help clarify the definition of this column (logged is a little ambiguous to me and doesn't match with how the numbers are reported later on in the notebook)
  • I'd recommend adding a subquery to also find all sessions that have a recorded init action to match the approach proposed by Kaldari. The query currently assumes that all saveSuccess events also have an init action recorded. To check, I ran the 2019 query with the init actions added (See P11437 ) and came up with slightly different results so that might not be the case.

Let me know if you have any questions or want to set up a quick call to discuss.

Thanks Megan for your inputs!!