Avoid hyphenation in URLs that span multiple lines
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Shreyasminocha
	Aug 21 2019, 6:21 AM

Description

Steps to Reproduce:

Visit the demo page (User:ShreyasMinocha/URL_Hyphenation_Demo) I made on a desktop with the minerva skin. At a viewport width of ≥720 px, www.anexample.com. This is not an issue with the vector skin.

Actual Results:

in the website field of the infobox breaks over into www.anexam-ple.com presumably due to insufficient space in the infobox. The hyphenation, in my opinion, can be misleading. As an anecdote, I was reading a particular page, where I knew the associated URL, but reading the hyphenated version confused me. When I tried editing the page to fix the URL, I noticed that the URL was, in fact, correct—it was just being displayed incorrectly.

Expected Results:

If there is insufficient space in the infobox, the text should break, but without hyphenation.

OS and Browser details:

macOS Mojave 10.14.5 Beta (18F131a).
FireFox Quantum 68.0.2 (64-bit). I cannot reproduce the issue with Brave Version 0.67.125 Chromium: 76.0.3809.100 (Official Build) (64-bit) and Safari Version 12.1.1 (14607.2.6.1.1).

Screenshots:

screenshot 2019-08-21 at 11.37.56 AM.jpg (356×670 px, 38 KB)

QA steps

Visit https://en.wikipedia.org/wiki/User:ShreyasMinocha/URL_Hyphenation_Demo?useskin=minerva on iPhone5S (320x568) and confirm no hyphen is present.

Details

	Subject	Repo	Branch	Lines +/-
	Disable hyphenation for links	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rSKIN2d3966ad2f65: Update git submodules

Event Timeline

Shreyasminocha created this task.Aug 21 2019, 6:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2019, 6:21 AM

Change 530783 had a related patch set uploaded (by Shreyasminocha; owner: Shreyasminocha):
[mediawiki/skins/MinervaNeue@master] Disable hyphenation for links

https://gerrit.wikimedia.org/r/530783

gerritbot added a project: Patch-For-Review.Aug 21 2019, 6:24 AM

Aklapper renamed this task from Hyphenation in URLs in infoboxes to Avoid hyphenation in URLs in infoboxes.Aug 21 2019, 10:30 PM

Aklapper awarded a token.

Thanks for opening the ticket!
I'm not sure about this as hyphens as the CSS rule you've suggested would apply to every single link - and hyphenating might be important.

Paging @alexhollender and @Volker_E who would be best placed to confirm whether it's okay to remove the hyphen.

It's fine to remove the hyphen.

en.m.wikipedia.org_wiki_User_ShreyasMinocha_URL_Hyphenation_Demo_useskin=minerva(iPhone 5_SE).png (1×640 px, 78 KB)

Okay merging!

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Aug 26 2019, 6:59 PM

Change 530783 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Disable hyphenation for links

https://gerrit.wikimedia.org/r/530783

Restricted Repository Identity mentioned this in rSKIN2d3966ad2f65: Update git submodules.Aug 26 2019, 11:30 PM

Thanks for your patience and patch submission @Shreyasminocha!

Jdlrobson updated the task description. (Show Details)Aug 26 2019, 11:51 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 27 2019, 12:01 AM

ovasileva assigned this task to • Niedzielski.Aug 27 2019, 5:08 PM

LGTM. Tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:ShreyasMinocha/URL_Hyphenation_Demo?useskin=minerva on an emulated device.

	F30117850: en.m.wikipedia.org_wiki_User_ShreyasMinocha_URL_Hyphenation_Demo_useskin=minerva(iPhone 5_SE).png
	Aug 26 2019, 6:09 PM