Page MenuHomePhabricator
Create Task
Maniphest T230786

Handle language codes containing numbers
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  • make a request to termbox using es-419 as the language code

Actual Results:

  • validation error

Expected Results:

  • no error, results shown in the requested language

Details

SubjectRepoBranchLines +/-
Allow numeric characters in language codeswikibase/termboxmaster+25 -2
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Aug 20 2019, 10:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2019, 10:31 AM
Jakob_WMDE updated the task description. (Show Details)Aug 20 2019, 11:45 AM
gerritbot added a comment.Aug 20 2019, 11:45 AM

Change 531160 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Allow numeric characters in language codes

https://gerrit.wikimedia.org/r/531160

gerritbot added a project: Patch-For-Review.Aug 20 2019, 11:45 AM
Jakob_WMDE moved this task from To Do to Peer Review on the Wikibase-Termbox-Iteration-20 board.Aug 20 2019, 12:37 PM
gerritbot added a comment.Aug 20 2019, 2:44 PM

Change 531160 merged by jenkins-bot:
[wikibase/termbox@master] Allow numeric characters in language codes

https://gerrit.wikimedia.org/r/531160

Jakob_WMDE mentioned this in rWBTBc36dc2bb6254: Allow numeric characters in language codes.Aug 20 2019, 3:05 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2019, 3:10 PM
Michael mentioned this in T265485: Termbox SSR should only be called with valid term languages.Oct 14 2020, 3:44 PM
Esc3300 added a project: Language codes.Jun 11 2021, 10:35 PM
Esc3300 subscribed.

Does this work now? see diff

Esc3300 moved this task from Backlog to MediaWiki core on the Language codes board.Jun 11 2021, 10:36 PM
Esc3300 moved this task from MediaWiki core to Monitoring on the Language codes board.Jun 12 2021, 10:09 AM
Esc3300 changed the task status from Open to Stalled.Jun 21 2021, 8:23 AM

@Jakob_WMDE I'm changing status to "stalled" given that it's unclear if anything is still needed.

Lydia_Pintscher closed this task as Resolved.Jun 27 2021, 2:47 PM
Lydia_Pintscher subscribed.

Patch is merged so let's assume it is resolved.

Esc3300 mentioned this in T286031: add language name "Latin American Spanish" for code "es-419" to LocalNamesEn.php.Jul 2 2021, 10:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits