Page MenuHomePhabricator
Create Task
Maniphest T154622

Hidden HTML comments are in very light grey and hard to read
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Quiddity
Jan 4 2017, 10:31 PM
Tags
Referenced Files
F28665758: image.png
Apr 15 2019, 5:21 PM
F28665769: image.png
Apr 15 2019, 5:21 PM
F5307807: unspecified.png
Jan 18 2017, 5:56 PM
F5230556: Selection_001.png
Jan 4 2017, 10:31 PM
Subscribers
Aklapper
DLynch
Jdforrester-WMF
matmarex
Quiddity
Volker_E

Description

This HTML comment is hard to read, and should follow our accessibility standards.

Selection_001.png (512×739 px, 33 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (33847a3ec)mediawiki/extensions/VisualEditormaster+1 -1
Remove de-emphasis color from comment contextVisualEditor/VisualEditormaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Jan 4 2017, 10:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2017, 10:31 PM
Quiddity mentioned this in T154624: Hidden HTML comments are not selectable text.Jan 4 2017, 10:38 PM
Volker_E subscribed.Jan 5 2017, 3:45 AM

Oh, there's some image transformation magic going on. The color of the Gifs seems to be maximum #919191.
The text inside the dialog is currently #555. Our minimum level AA color in M82 is #72777d, which should be used for the image and #54595d or even #222 for the dialog.

DLynch subscribed.Jan 18 2017, 5:56 PM

For what it's worth, here's what it actually looks like without whatever strange color-shifting is going on there:

unspecified.png (320×846 px, 49 KB)

Jdforrester-WMF changed the task status from Open to Stalled.Mar 7 2017, 8:24 PM
Jdforrester-WMF subscribed.

This is light to avoid taking the user's eye. The alternative was not having the text shown at all, which you also disliked.

gerritbot added a comment.Apr 14 2019, 2:36 PM

Change 503751 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove de-emphasis color from comment context

https://gerrit.wikimedia.org/r/503751

gerritbot added a project: Patch-For-Review.Apr 14 2019, 2:36 PM
gerritbot added a comment.Apr 14 2019, 9:58 PM

Change 503751 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove de-emphasis color from comment context

https://gerrit.wikimedia.org/r/503751

matmarex subscribed.Apr 15 2019, 5:21 PM
BeforeAfter
image.png (175×443 px, 9 KB)
image.png (175×443 px, 9 KB)
matmarex changed the task status from Stalled to Open.Apr 15 2019, 5:21 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
matmarex moved this task from Unsorted to Colors on the Accessibility board.
matmarex moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 15 2019, 6:42 PM

Change 504075 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (33847a3ec)

https://gerrit.wikimedia.org/r/504075

gerritbot added a comment.Apr 15 2019, 7:13 PM

Change 504075 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (33847a3ec)

https://gerrit.wikimedia.org/r/504075

Jdforrester-WMF assigned this task to Esanders.Apr 15 2019, 7:37 PM
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor-EditingTools; removed Patch-For-Review.
JTannerWMF added a project: Skipped QA.May 23 2019, 6:47 PM
ppelberg closed this task as Resolved.Jun 18 2019, 12:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits