Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BundleInstall! and changelog doesn't work on windows #192

Closed
gudezhi opened this issue Jul 8, 2012 · 10 comments
Closed

BundleInstall! and changelog doesn't work on windows #192

gudezhi opened this issue Jul 8, 2012 · 10 comments

Comments

@gudezhi
Copy link

gudezhi commented Jul 8, 2012

The log looks like this.

[120708 19:24:49] Bundle gmarik/vundle
[120708 19:24:49] $ "cd /d "D:\tools\vim\vimfiles\vbundle\vundle" && git pull"
[120708 19:24:49] > The filename, directory name, or volume label syntax is incorrect.

Remove the

let cmd='"'.cmd.'"'
makes it work,
but I don't know why the quote works fine for others so far.

@gmarik
Copy link
Contributor

gmarik commented Jul 8, 2012

Hey @gudezhi, thanks for reporting!

@zolrath could you please take a look at this?!

@Taverius
Copy link

This is what happens when you have post-.456(?) ViM and you don't set shellxquote="" in your .vimrc

@gudezhi
Copy link
Author

gudezhi commented Jul 16, 2012

Thanks!
I am using the 7.3.586 VIM, and set shellxquote="" makes it work!

But is it the one that man should take care of it in .vimrc?
or vundle should take care of it?

@Taverius
Copy link

No, vundle can't (easily), shellxquote="" breaks things instead of fixing them before VIM patch 445. See #146.

@gudezhi
Copy link
Author

gudezhi commented Jul 16, 2012

I see. Thanks any way. I will close it.

@gudezhi gudezhi closed this as completed Jul 16, 2012
@gmarik
Copy link
Contributor

gmarik commented Jul 17, 2012

@Taverius, thanks for helping out!
Appreciated!

@gmarik
Copy link
Contributor

gmarik commented Jul 17, 2012

Should Wiki be updated regarding shellxquote related issues on Windows?
This is fairly common issue...

@Taverius
Copy link

I was going to suggest that, yes, at least until/unless we find a better solution.

I'm not sure if there's a way to test for the need of it using command.com/cmd.exe builtins, I say put it in the wiki and we can try to figure something out in #146.

@jdevera
Copy link
Contributor

jdevera commented Jul 17, 2012

We can query the version by comparing against v:version and the patches applied with has("patchXXX"). Would it be safe to setshellxquote` if the right combination is found, or is it exclusively a vimrc thing?

@Taverius
Copy link

You can setlocal shellxquote=""and VIM doesn't complain, so I say we try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants