Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective of test: "Verify ONNX with ONNX Runtime PyPI package"? #6484

Open
andife opened this issue Oct 22, 2024 · 2 comments
Open

Objective of test: "Verify ONNX with ONNX Runtime PyPI package"? #6484

andife opened this issue Oct 22, 2024 · 2 comments
Labels
question Questions about ONNX

Comments

@andife
Copy link
Member

andife commented Oct 22, 2024

Ask a Question

Question

What exactly do we try to test here? When should/could we upgrade onnxruntime and the other two variables?
Maybe we can the rule/idea in a comment? Could we use python 3.12 now? Comparing the different os, I would assume at lease_linux_aarch64, it should also be onnxruntime==1.17.3 ?


release_linux_aarch64.yml
    - name: Verify ONNX with ONNX Runtime PyPI package
      if: matrix.python-version != 'cp312-cp312'
      run: |
         docker run --rm -v ${{ github.workspace }}:/ws:rw --workdir=/ws \
          ${{ env.img }} \
          bash -exc '\
          source .env/bin/activate && \
          python -m pip uninstall -y protobuf numpy && python -m pip install -q -r requirements-release.txt && \
          python -m pip install -q onnxruntime==1.16.3 && \
          export ORT_MAX_IR_SUPPORTED_VERSION=9 \
          export ORT_MAX_ML_OPSET_SUPPORTED_VERSION=3 \
          export ORT_MAX_ONNX_OPSET_SUPPORTED_VERSION=20 \
          pytest && \
          deactivate'

release_linux_x86_64.ym
    - name: Verify ONNX with ONNX Runtime PyPI package
      if: matrix.python-version != '3.12'
      run: |
        python -m pip uninstall -y protobuf numpy && python -m pip install -q -r requirements-release.txt
        python -m pip install -q onnxruntime==1.17.3
        export ORT_MAX_IR_SUPPORTED_VERSION=9
        export ORT_MAX_ML_OPSET_SUPPORTED_VERSION=3
        export ORT_MAX_ONNX_OPSET_SUPPORTED_VERSION=20
        pytest

release_win.yml
    - name: Verify ONNX with ONNX Runtime PyPI package
      if: matrix.python-version != '3.12'
      run: |
        cd onnx
        python -m pip uninstall -y protobuf numpy
        python -m pip install -q -r requirements-release.txt
        python -m pip install -q onnxruntime==1.17.3
        $Env:ORT_MAX_IR_SUPPORTED_VERSION=9
        $Env:ORT_MAX_ML_OPSET_SUPPORTED_VERSION=3
        $Env:ORT_MAX_ONNX_OPSET_SUPPORTED_VERSION=20
        pytest

release_mac.yml
    - name: Verify ONNX with ONNX Runtime PyPI package
      if: matrix.python-version != '3.12'
      run: |
        arch -${{ matrix.target-architecture }} python -m pip uninstall -y protobuf numpy
        arch -${{ matrix.target-architecture }} python -m pip install -q -r requirements-release.txt
        arch -${{ matrix.target-architecture }} python -m pip install -q onnxruntime==1.17.3
        export ORT_MAX_IR_SUPPORTED_VERSION=9
        export ORT_MAX_ML_OPSET_SUPPORTED_VERSION=3
        export ORT_MAX_ONNX_OPSET_SUPPORTED_VERSION=20
        arch -${{ matrix.target-architecture }} pytest
@andife andife added the question Questions about ONNX label Oct 22, 2024
@xadupre
Copy link
Contributor

xadupre commented Oct 24, 2024

cc @gramalingam The only place onnxruntime is used should be here: #6214. I don't think onnxruntime is really used right now so unless this PR is merged, upgrading onnxruntime or removing it should have no impact.

@andife
Copy link
Member Author

andife commented Oct 31, 2024

My option would be to delete it for the time being as long as it is not being used? We can add it again in the other PR when it is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions about ONNX
Projects
None yet
Development

No branches or pull requests

2 participants